Closed sbernauer closed 5 months ago
IMHO it's not worth an immediate bugfix release, as there is a workaround available.
I would be happy to release a new version, because there are now multiple things which are unreleased.
I would however do one additional PR regarding the changelog before bumping the version.
I already changed the wording the "bugfix platform version", sorry for the confusion. No objections against op-rs release whatsoever
I tried diffing the output before/after this patch: https://gist.github.com/nightkr/9446c9e3747aa6f58ce616cd86c1f13e
As far as I can tell, the actual issue here is that schemars doesn't propagate additionalProperties
when used with #[serde(flatten)]
? We should probably file an upstream ticket for that and link to it in the code.
This looks like https://github.com/GREsau/schemars/issues/259.
https://github.com/GREsau/schemars/pull/275 generates the schema https://gist.github.com/nightkr/f7f06df7a14286a9b682ad6be7e3da14, which should also contain the correct additionalProperties
.
Another workaround is to add #[schemars(deny_unknown_fields)]
to StackableNodeSelector
: https://gist.github.com/nightkr/af2236b2d3cf77eb71242124d588a638
Many thanks for tracking this down @nightkr! What would you suggest as the next step?
#[schemars(deny_unknown_fields)]
@sbernauer I'd say 2 and add a tracking issue for 3. schemars doesn't look too lively these days so we shouldn't block on it.
Makes sense to me! Adopted Option 2 and created https://github.com/stackabletech/operator-rs/issues/756. A quick review would be great, so that @Techassi can release :)
Description
Fixes https://github.com/stackabletech/issues/issues/554.
IMHO it's not worth an immediate platform bugfix release, as there is a workaround available.
The effect can be seen e.g. in Trino:
Definition of Done Checklist