stackabletech / operator-rs

A simple wrapper/framework around kube-rs to make implementing Operators/Controllers easier

Apache License 2.0

116 stars 12 forks source link

chore: implement PartialEq for most Snafu Error enums #757

Closed NickLarsenNZ closed 5 months ago

NickLarsenNZ commented 5 months ago

Description

This change is to encourage testing error variants by type rather than text contents.

Bump strum to 0.26.2
Derive PartialEq on most Snafu Error enums.
Add custom implementations of PartialEq for Snafu error enums that use types that are not directly comparable.

[!IMPORTANT] Some variants are impossible to compare, so these implementations are restricted to #[cfg(test)] because they cause panics.

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added