stackabletech / operator-rs

A simple wrapper/framework around kube-rs to make implementing Operators/Controllers easier

Apache License 2.0

116 stars 12 forks source link

chore!: remove thiserror (add module-scoped errors with the help of `snafu`) #761

Closed NickLarsenNZ closed 5 months ago

NickLarsenNZ commented 5 months ago

Description

:rotating_light: Breaking

Remove deprecated exports
Remove thiserror and move all errors to module-scoped error enums
- Fix error text based on the Source code style guide
- Replace ok_or and map_err with context or with_context.
- Replaced return Err(Error::Xxx) with return XxxSnafu.fail().
- Created consistent Result<T, E = Error> type-aliases, and moved them to below the imports section. (Replaced Result<T> type-aliases which enforced the error type).

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Author
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

sbernauer commented 5 months ago

FYI @Maleware (just testing notifications)