stackabletech / operator-rs

A simple wrapper/framework around kube-rs to make implementing Operators/Controllers easier
Apache License 2.0
116 stars 12 forks source link

fix: Remove duplicate authority key identifier extension #766

Closed Techassi closed 4 months ago

Techassi commented 4 months ago

Without removing this duplicate extension, the Go X.509 parsing code would error out stating that the "certificate contains duplicate extensions", which was indeed correct.

We accidentally included the authority key identifier twice, once in the leaf profile and once by manually adding the extension after building the cert.

We now removed the manually added extension. This resolved the Go error and the HTTP client was able to establish a TLS-secured connection to the dummy webhook.

See merge: https://go-review.googlesource.com/c/go/+/383215 See code: https://github.com/golang/go/blob/315b6ae682a2a4e7718924a45b8b311a0fe10043/src/crypto/x509/parser.go#L965-L968


To be able to access the OID of the duplicate extension, it was required to change Go's standard library. I will provide an upstream patch to improve the error message.

Also see the follow-up issue #694 to add tests / assertions around correct certificate generation.