stackabletech / operator-rs

A simple wrapper/framework around kube-rs to make implementing Operators/Controllers easier
Apache License 2.0
112 stars 11 forks source link

Product image selection: only override version for PR builds #812

Closed nightkr closed 1 month ago

nightkr commented 1 month ago

Description

Originally introduced in #629.

Also adds logging because this was pretty confusing to me.

Definition of Done Checklist

# Author
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
nightkr commented 1 month ago

I would have never done that, but I guess there could be reasons for that ;)

I wanted to run the whole test suite against my custom build. Given the choice between changing each individual test to refer to it or changing the default, guess which one is less annoying.. :P

sbernauer commented 1 month ago

That's clever! ;)