stackabletech / operator-rs

A simple wrapper/framework around kube-rs to make implementing Operators/Controllers easier

Apache License 2.0

112 stars 11 forks source link

Add option to log to file #814

Open nightkr opened 1 month ago

nightkr commented 1 month ago

Description

Fixes #795

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Author
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [x] Code contains useful comments
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

nightkr commented 3 weeks ago

One downside here is that tracing-appender rotates based on time rather than disk space, so we can no longer provide strict guarantees that the logs will never outgrow their respective volumes... There are PRs up for addressing this already (see https://github.com/tokio-rs/tracing/issues/2972: https://github.com/tokio-rs/tracing/pull/2904, https://github.com/tokio-rs/tracing/pull/2497) but none that have been merged yet.

sbernauer commented 3 weeks ago

Well that's a pity :/

sbernauer commented 2 days ago

@siegfriedweber would you be willing to review this PR? I think you are the best person to do so, as you can best asses the so we can no longer provide strict guarantees that the logs will never outgrow their respective volumes problem. Maybe this is a blocker (given customers already had problems with the volume sizes), maybe not.

Also you know the vector transformation far better