stackabletech / operator-rs

A simple wrapper/framework around kube-rs to make implementing Operators/Controllers easier
Apache License 2.0
122 stars 13 forks source link

`ClusterResources::delete_orphaned_resources` also deletes objects that are not owned directly by it #861

Closed nightkr closed 1 month ago

nightkr commented 1 month ago

For example:

Arguably, this is actually two separate bugs that should both be resolved separately:

lfrancke commented 1 month ago

This is a bug that exists in a released SDP version?

nightkr commented 1 month ago

Yesn't. Pretty sure that it was present in a older versions (haven't done a deep dive, but I suspect the logic hasn't changed significantly since back in #436) but that we didn't trigger it before now (because we didn't use the features yet that made it problematic). So it was a bug in op-rs, but not in SDP.