Java properties: don't write quotes for empty strings

[nightkr]

Description

That is, ("foo", Some("")) will now be serialized as foo= rather than foo="".

This is because Java (or at least Kafka...) seems to interpret the latter as a string literally containing the characters "".

Review Checklist

• [ ] Code contains useful comments
• [ ] (Integration-)Test cases added (or not applicable)
• [ ] Documentation added (or not applicable)
• [ ] Changelog updated (or not applicable)

[lfrancke]

I'm afraid to run a blame on the original code but I'm willing to bet that this was a delibarate move because some other tool does need those quotes in some scenarios under a full moon.

[nightkr]

It seems to date back to https://github.com/stackabletech/product-config/pull/25/files#r661547454, and originally came from c784188a3d2213004cec7c2ef16672e6a8dd3eb6...

[lfrancke]

I don't see a justificaton there. I think the Java properties javadoc can be misread/misinterpreted in a way that an empty value is "". So, I'm fine wtih the change in general.

[nightkr]

@razvan / @maltesander what do you think?

[nightkr]

bors r+

[bors[bot]]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• Run cargo deny (bans licenses sources)
• Run clippy
• Run rustdoc
• Run rustfmt
• Run tests