stackabletech / secret-operator

Other

12 stars 6 forks source link

feat: Support non-default cluster domain #510

Closed maltesander closed 3 weeks ago

maltesander commented 4 weeks ago

Description

Part of https://github.com/stackabletech/issues/issues/652

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

sbernauer commented 3 weeks ago

Tests passed locally

--- PASS: kuttl (251.94s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/kerberos_krb5-1.21.1_openshift-false (63.91s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-2048 (161.45s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-3072 (30.64s)
        --- PASS: kuttl/harness/listener_openshift-false (135.98s)
        --- PASS: kuttl/harness/cert-manager-tls_openshift-false (59.85s)
PASS