stackabletech / spark-k8s-operator

Operator for Apache Spark-on-Kubernetes for Stackable Data Platform
https://stackable.tech
Other
49 stars 2 forks source link

feat: Default stackableVersion to operator version #267

Closed sbernauer closed 11 months ago

sbernauer commented 11 months ago

Description

Part of https://github.com/stackabletech/issues/issues/404

Definition of Done Checklist

# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
lfrancke commented 10 months ago

Did this change the CRD? Is this a breaking change?

maltesander commented 10 months ago

Should not be breaking. You can still set the stackable version, or if left out (new) will default to operator version.

lfrancke commented 10 months ago

But did it change the CRD?

lfrancke commented 10 months ago

This needs a release note entry saying that we switched the default PullPolicy

sbernauer commented 10 months ago

Yeah, that sounds like a good idea. Given that we would need to touch the Changelog in every operator, would it be sufficient to mention the change in the platform release notes?