stackabletech / spark-k8s-operator

Operator for Apache Spark-on-Kubernetes for Stackable Data Platform
https://stackable.tech
Other
51 stars 3 forks source link

Use resolved product version #275

Closed razvan closed 1 year ago

razvan commented 1 year ago

Description

Depends on https://github.com/stackabletech/docker-images/pull/436

Part of : https://github.com/stackabletech/spark-k8s-operator/issues/273

:green_circle: OpenShift tests with custom image:

--- PASS: kuttl (1029.69s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-examples_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (80.30s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (122.61s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (164.82s)
        --- PASS: kuttl/harness/resources_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (103.91s)
        --- PASS: kuttl/harness/pod_overrides_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (171.40s)
        --- PASS: kuttl/harness/logging_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (450.57s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (136.31s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (103.35s)
        --- PASS: kuttl/harness/smoke_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (204.52s)
        --- PASS: kuttl/harness/spark-history-server_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (278.84s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (139.17s)
PASS

Definition of Done Checklist

# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
lfrancke commented 1 year ago

Does this change the CRD?

razvan commented 1 year ago

Yes. It makes the CRD more in line with the others.

lfrancke commented 1 year ago

So, we need a release note entry? Anything else for the next release to be aware of here?

lfrancke commented 1 year ago

@razvan Do we need any migration steps or anything else for the next version?

razvan commented 1 year ago

We need an entry in the release notes that shows both the old and the new way.