stackabletech / spark-k8s-operator

Operator for Apache Spark-on-Kubernetes for Stackable Data Platform
https://stackable.tech
Other
47 stars 2 forks source link

fix: Remove userClassPathFirst properties #355

Closed razvan closed 4 months ago

razvan commented 4 months ago

Fixes #354

razvan commented 4 months ago

CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/122/

razvan commented 4 months ago

CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/123/

razvan commented 4 months ago

Tests pass on OpenShift 4.13:

--- PASS: kuttl (1670.68s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-true_spark-3.5.0 (167.41s)
        --- PASS: kuttl/harness/spark-history-server_openshift-true_spark-3.5.0_s3-use-tls-true (409.71s)
        --- PASS: kuttl/harness/smoke_openshift-true_spark-3.5.0_s3-use-tls-true (282.40s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-true_spark-3.5.0_ny-tlc-report-0.1.0 (207.65s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-true_spark-3.5.0 (245.33s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-true_spark-3.5.0 (167.31s)
        --- PASS: kuttl/harness/iceberg_spark-3.5.0 (115.25s)
        --- PASS: kuttl/harness/spark-examples_openshift-true_spark-3.5.0 (102.49s)
        --- PASS: kuttl/harness/pod_overrides_openshift-true_spark-3.5.0 (231.25s)
        --- PASS: kuttl/harness/resources_openshift-true_spark-3.5.0 (131.30s)
        --- PASS: kuttl/harness/logging_openshift-true_spark-3.5.0_ny-tlc-report-0.1.0 (544.06s)
        --- PASS: kuttl/harness/delta_spark-delta-3.5.0_delta-3.1.0 (281.07s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-true_spark-3.5.0_s3-use-tls-true (231.64s)
PASS
soenkeliebau commented 4 months ago

Tests pass on OpenShift 4.13:

this is super sexy :)

NickLarsenNZ commented 4 months ago

re-running the failed job (503 from docker login)

razvan commented 4 months ago

I would be ok with merging this, but I would really like us solving the classpath problem with the logging libs instead of ripping out logging :)

What do you mean "ripping out logging" ? Logs from applications are not affected by this change.

razvan commented 4 months ago

CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/124/