stackanetes / kubernetes-entrypoint

Used as a container entrypoint, it will wait for specified k8s dependencies, create files based on ConfigMaps, and much more - before running a given command.
Apache License 2.0
50 stars 18 forks source link

Use os.Hostname() instead of HOSTNAME env variable #7

Closed Quentin-M closed 8 years ago

Quentin-M commented 8 years ago

The assumption was made that the HOSTNAME environment variable was available. While it is the case in Docker containers, it is not in rkt containers. By using os.Hostname(), we have the guarantee that we'll retrieve the hostname with both runtimes.

PiotrProkop commented 8 years ago

LGTM