The address of the bot comment does not contain the updated code.

warmthsea commented 1 week ago

PR create bot commit: https://github.com/warmthsea/element-plus/pull/18#issuecomment-2336576214 (Does not include updated code)

PR update code: https://github.com/warmthsea/element-plus/pull/18/checks?check_run_id=29967470452

Does the original comment address need to be updated?

Aslemammad commented 6 days ago

Yep, the address of the pull request comment should not change since it addresses the latest commit of the PR always when you put the number of the PR there.

But the check run is what gets updated, when you visit the check run (commit: 3b1av3f) it contains the built package for that specific hash.

warmthsea commented 6 days ago

Yep, the address of the pull request comment should not change since it addresses the latest commit of the PR always when you put the number of the PR there.

But the check run is what gets updated, when you visit the check run (commit: 3b1av3f) it contains the built package for that specific hash.

But when executing ↓, the installed build product is the original one, not the latest one. Is this by design?

(18 represents pr floor)

pnpm add https://pkg.pr.new/warmthsea/element-plus@18

Aslemammad commented 6 days ago

I think this is because of caching!

Can you try adding the -f flag and let me know!

warmthsea commented 6 days ago

I think this is because of caching!

Can you try adding the -f flag and let me know!

Thank you very much for your reply. I have some doubts. Regarding whether the initial comment address of the installation is the latest code.

Info:

window 11 npm origin: https://registry.npmjs.org/ (default settings) use pnpm version: 9.9.0 node version: v21.7.3 chrome、firefox

test pr: https://github.com/warmthsea/element-plus/pull/20 test install repo: https://github.com/warmthsea/elp-pkg-pr-release-test

Step:

1、install pr Bot first commit link

pnpm add https://pkg.pr.new/warmthsea/element-plus@20

2、update warmthsea/element-plus components 3、wait for pkg.pr.new ci to complete 4、again install

pnpm add https://pkg.pr.new/warmthsea/element-plus@20

1、use Vercel deploy

execute in a short time (demo) (update content not effective)
execute in one minute (demo) (effective)

2、run locally (dev)

all time (not effective, I thinks it should take effect)

try:

delete pnpm-lock.yaml
again clone repo
delete node_modules
pnpm i xx --force

none of them took effect.

Aslemammad commented 6 days ago

Hmm, but as I curl, it addresses the latest commit!

stackblitz-labs / pkg.pr.new

The address of the bot comment does not contain the updated code. #235

Info:

Step: