Prevent auto-scroll to iframe

stackblitz / core

Online IDE powered by Visual Studio Code ⚡️

https://stackblitz.com

MIT License

10.34k stars 931 forks source link

Prevent auto-scroll to iframe #1653

Closed NetanelBasal closed 3 years ago

NetanelBasal commented 3 years ago

Description of Bug

When using the SDK it auto scrolls to the iframe.

Steps to Reproduce

See it live on every page here https://ngneat.github.io/elf/docs/store

Expected Behavior

Stop the auto-scroll.

fvsch commented 3 years ago

Hi @NetanelBasal, thanks for the report! We’re looking into it.

fvsch commented 3 years ago

Hi again @NetanelBasal. We shipped an update which seems to fix the issue on https://ngneat.github.io/elf/docs/store and other pages using StackBlitz embeds. Can you give it a try and confirm?

As a side note, I think you can make a couple tweaks to your embedding code:

We recently pushed an SDK update that lets you set devToolsHeight: 100. I saw that you were using devToolsHeight: 99 as a workaround. Make sure you're using the latest SDK version.
I would recommend using the forceEmbedLayout: true option, if you think that layout works for your use case. In a future major version of the SDK (likely 2.0), we’ll probably set the default value to true for that option.

NetanelBasal commented 3 years ago

Yes, it works perfectly.

Great, I'll set the height to 100 and check the forceEmbedLayout option.

Thanks!

thescientist13 commented 3 years ago

Thanks for the fix! We just observed this issue ourselves the other day and now it has gone away. 🙇‍♂️

Char2sGu commented 1 year ago

@thescientist13 The issue is not solved, it's back again. Checkout https://ngneat.github.io/elf/docs/store and you can see the page scrolls to the iframe again now!

Enngage commented 1 year ago

We are seeing the same issue, can you please add an option for disabling cursor focus?

shhdharmen commented 1 year ago

I am also facing same issue.

kamranayub commented 1 year ago

Can also confirm it's happening (in Chrome, Firefox seems okay). Exact same issue as above.

FYI @thescientist13 it's happening for you again too at https://www.greenwoodjs.io/getting-started/quick-start/

As a workaround, I am using clickToLoad: true for now but that's not ideal, I prefer the live view 😄

thescientist13 commented 2 months ago

seems like this is happening again?

NielsCodes commented 1 month ago

seems like this is happening again?

It was never fixed to begin with