StackBlitz SDK do not install dependencies

nsbarsukov commented 2 years ago

Description of Bug

We actively use Stackblitz SDK for a long time. But recently it stopped installing requested dependencies after sdk.openProject-command.

Steps to Reproduce

Open this HTML-file in browser

HTML-file starter with NO bug

```html ```

Everything is nice. All required dependencies is installed.

Open this HTML-file

HTML-file starter WITH BUG

```html ```

The dependencies are not installed (all of them)!

Expected Behavior

All dependencies are installed. Or at least Stackblitz throws descriptive error what goes wrong.

Additional Context/Questions We are looking forward to bug fix because we actively use Stackblitz inside our Taiga UI. We will really appreciate if you can handle this.

splincode commented 2 years ago

out dependencies for @taiga-ui/addon-editor

{
    "name": "@taiga-ui/addon-editor",
    "version": "3.10.0",
    "description": "Rich text editor extension package for Taiga UI",
    "keywords": [
        "angular",
        "component",
        "wysiwyg",
        "rich",
        "text",
        "editor"
    ],
    "homepage": "https://github.com/tinkoff/taiga-ui",
    "repository": "https://github.com/tinkoff/taiga-ui",
    "license": "Apache-2.0",
    "dependencies": {
        "@tiptap/core": "2.0.0-beta.199",
        "@tiptap/extension-bold": "2.0.0-beta.199",
        "@tiptap/extension-bubble-menu": "2.0.0-beta.199",
        "@tiptap/extension-bullet-list": "2.0.0-beta.199",
        "@tiptap/extension-code": "2.0.0-beta.199",
        "@tiptap/extension-code-block": "2.0.0-beta.199",
        "@tiptap/extension-document": "2.0.0-beta.199",
        "@tiptap/extension-dropcursor": "2.0.0-beta.199",
        "@tiptap/extension-gapcursor": "2.0.0-beta.199",
        "@tiptap/extension-hard-break": "2.0.0-beta.199",
        "@tiptap/extension-heading": "2.0.0-beta.199",
        "@tiptap/extension-history": "2.0.0-beta.199",
        "@tiptap/extension-horizontal-rule": "2.0.0-beta.199",
        "@tiptap/extension-image": "2.0.0-beta.199",
        "@tiptap/extension-italic": "2.0.0-beta.199",
        "@tiptap/extension-link": "2.0.0-beta.199",
        "@tiptap/extension-list-item": "2.0.0-beta.199",
        "@tiptap/extension-ordered-list": "2.0.0-beta.199",
        "@tiptap/extension-paragraph": "2.0.0-beta.199",
        "@tiptap/extension-placeholder": "2.0.0-beta.199",
        "@tiptap/extension-strike": "2.0.0-beta.199",
        "@tiptap/extension-subscript": "2.0.0-beta.199",
        "@tiptap/extension-superscript": "2.0.0-beta.199",
        "@tiptap/extension-table": "2.0.0-beta.199",
        "@tiptap/extension-table-cell": "2.0.0-beta.199",
        "@tiptap/extension-table-header": "2.0.0-beta.199",
        "@tiptap/extension-table-row": "2.0.0-beta.199",
        "@tiptap/extension-text": "2.0.0-beta.199",
        "@tiptap/extension-text-align": "2.0.0-beta.199",
        "@tiptap/extension-text-style": "2.0.0-beta.199",
        "@tiptap/extension-underline": "2.0.0-beta.199",
        "@tiptap/starter-kit": "2.0.0-beta.199",
        "prosemirror-collab": "~1.3.0",
        "prosemirror-commands": "~1.3.1",
        "prosemirror-dropcursor": "~1.6.1",
        "prosemirror-gapcursor": "~1.3.1",
        "prosemirror-history": "~1.3.0",
        "prosemirror-inputrules": "~1.2.0",
        "prosemirror-keymap": "~1.2.0",
        "prosemirror-model": "~1.18.1",
        "prosemirror-schema-list": "~1.2.2",
        "prosemirror-state": "~1.4.2",
        "prosemirror-tables": "~1.2.5",
        "prosemirror-transform": "~1.7.0",
        "prosemirror-utils": "~0.9.6",
        "prosemirror-view": "~1.29.0",
        "tslib": "^2.0.0"
    },
    "peerDependencies": {
        "@angular/common": ">=9.0.0",
        "@angular/core": ">=9.0.0",
        "@angular/forms": ">=9.0.0",
        "@angular/platform-browser": ">=9.0.0",
        "@ng-web-apis/common": ">=2.0.0",
        "@taiga-ui/cdk": ">=3.10.0",
        "@taiga-ui/core": ">=3.10.0",
        "@taiga-ui/i18n": ">=3.10.0",
        "@taiga-ui/kit": ">=3.10.0",
        "rxjs": ">=6.0.0"
    }
}

AleksandrSl commented 2 years ago

Hi, thanks for the issue. Trying to install "@taiga-ui/addon-editor" gives me Screenshot from 2022-11-17 13-25-58 . We will take a look

splincode commented 2 years ago

But you can install that package from npm: https://www.npmjs.com/package/@taiga-ui/addon-editor

splincode commented 2 years ago

@AleksandrSl Hmm null@1.1.3

AleksandrSl commented 2 years ago

Indeed, installing "@_ueberdosis/prosemirror-tables" gives weird results. Without version specified, it's installed without errors but is not listed in installed packages. Specifying the version gives the same error.

Unfortunately, I'm not experienced in our resolver internals, but I contacted the right person. Hope we will resolve this soon.

markwhitfeld commented 2 years ago

After some investigation, the underscore in the @_ueberdosis/prosemirror-tables package name is causing the issues. We have updated to the latest version of the npm-package-arg library and it handles the package name parsing perfectly. Apparently the underscore is not compliant with the npm package scope specs, but because packages were published with this naming, support has now needed to be added. The fix will be released to production shortly. EDIT: Release delayed by node version incompatibility issues. Will aim for release tomorrow.

markwhitfeld commented 2 years ago

The fix for the issue has been deployed and confirmed working 👍

stackblitz / core