Closed fvsch closed 1 year ago
I'd drop
version
as well, but I don't have strong feelings about that.
Dropped it. I agree that it's not useful for projects.
For the package name, I think the
-starter
makes a bit more sense
Changed from -demo
suffix to -starter
suffix.
This PR harmonizes what basic config files we find in a starter template.
What's in
package.json
Almost all starters have a
package.json
file. I've tried to harmonize those files to follow this pattern:Some templates may not have
"scripts"
(most for some EngineBlock starters), some may not have"devDependencies"
.Open questions:
"{folder-name}-demo"
pattern okay, or do we want to use “starter” or “template” instead of “demo” maybe?npm info
will show information for that package merged with info from the localpackage.json
, which is quite strange, but maybe a very rare problem."version"
even useful? I’m tempted to just drop it.Removing all the
.stackblitzrc
filesAll the
.stackblitzrc
files in WebContainer projects were spelling out defaults, such as{ "installDependencies": true, startCommand: "npm run dev" }
.I removed them for the sake of readability, but if we want to include one with defaults in every WC starter template we could do that too.
Making sure every WC template has a
.gitignore
For every WebContainer-based template, I made sure it had a
.gitignore
file that listed at least:node_modules
.next
,.nuxt
,.svelte-kit
, etc.)npm run build
(build
,dist
, etc.)Harmonizing
index.html
files<!DOCTYPE html>
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width">
Harmonizing base CSS styles
We had base
style.css
files which looked like:That's not super useful, especially since the preview documents don't load the Lato fonts at all. (They used to, in EngineBlock projects, but we removed those fonts in early 2022 for performance reasons.)
Instead I'm proposing a very basic stylesheet looking like this: