Closed AriPerkkio closed 3 weeks ago
Run & review this pull request in StackBlitz Codeflow.
@Nemikolh this is now ready for final review and is no longer blocked by #238.
As this contains couple of fix
commits as well, it might be good to merge this without squashing so that the fixes will show up in release notes properly.
@AriPerkkio I think I can't push to main directly and I do not have access to other merge options.
Note that this would be contrary to our conventions and they've been used to get more details about a commit by looking at the PR number associated with a commit.
In the early days of TutorialKit it was possible but we then decided to always go through PRs.
Do you think you could submit a separate PR that contains all the fixes? Or multiple PRs if you prefer.
Oh I see, other merge options are completely disabled. It would be good to have squashing enabled by default, but allow rebase when needed.
I'll split this PR and move to fixes into separate PRs. 👍
Alright, good to go now. Other PRs are in main
and this one is up-to-date.
Requires https://github.com/stackblitz/tutorialkit/pull/238Structure
Test cases are located in
test
directory. Each test file has its ownchapter
, that containslesson
s for test cases:For example Navigation tests:
Or File Tree tests: