Closed AriPerkkio closed 2 months ago
Run & review this pull request in StackBlitz Codeflow.
@Nemikolh what do you think about adding https://pkg.pr.new to TutorialKit? Verifying changes like this would be really great if I could use real published packages. Relying on linked (file://
or link://
protocol on package.json
) doesn't provide good confidence. Package managers and Node resolving is weird.
Oh that would be really cool! I like a lot that idea :smiley:
/pkg-pr-new
⚡️ Your npm packages are published. @tutorialkit/astro: npm i https://pkg.pr.new/@tutorialkit/astro@967975b @tutorialkit/components-react: npm i https://pkg.pr.new/@tutorialkit/components-react@967975b @tutorialkit/runtime: npm i https://pkg.pr.new/@tutorialkit/runtime@967975b @tutorialkit/theme: npm i https://pkg.pr.new/@tutorialkit/theme@967975b @tutorialkit/types: npm i https://pkg.pr.new/@tutorialkit/types@967975b
/pkg-pr-new
Changes of this PR are now deployed and running at https://github.com/AriPerkkio/tutorial-vite-plugin/pull/21.
@Nemikolh I'm trying to think of all kinds of scenarios that should be tested there, mainly focusing on trying to see that user's own uno.config.ts
changes work. Does anything important that should be tested come to your mind?
@AriPerkkio Not that I can think of! We can always fix them later once we encounter them. Let's move forward with this PR
Moves all configuration from
uno.config.ts
behind@tutorialkit/theme
and@tutorialkit/astro
packages. Users are no-longer needed to have complexuno.config.ts
files in their projects. In cases like https://github.com/stackblitz/tutorialkit/pull/184 we no longer need to instruct users to modify theiruno.config.ts
- we can actually apply these in@tutorialkit
packages and just release them.Adds a custom
defineConfig
to@tutorialkit/theme
, that can be used to configure TutorialKit theme and add additional UnoCSS configurations:UnoCSS VS Code extension still works as expected:
Migration guide for projects:
In your
package.json
:In your
uno.config.ts
:BREAKING CHANGES:
@tutorialkit/astro
package no longer exportsunoCSSConfig
. UsedefineConfig
from@tutorialkit/theme
instead.@tutorialkit/theme
package no longer exportsrules
,shortcuts
andtheme
.@tutorialkit/theme
package exportstransitionTheme
from new entrypoint:@tutorialkit/theme/transition-theme
.