search

stackblitz / tutorialkit

TutorialKit by StackBlitz - Create interactive tutorials powered by the WebContainer API
https://tutorialkit.dev
MIT License
507 stars 49 forks source link

`Toggle Terminal` button should be hidden when `terminal: false` #300

Open AriPerkkio opened 2 months ago

AriPerkkio commented 2 months ago

Describe the bug

When terminal is disabled in metadata, the Toggle Terminal button is still visible. It just shows empty blank terminal when toggled.

Link to a StackBlitz project which shows the error

No response

Steps to reproduce

  1. Define in metadata: 
    ---
type: lesson
title: Test
terminal: false
---
  2. Open page and click Toggle Terminal

Expected behavior

Whole Toggle Terminal button should be hidden.

Screenshots

image

Platform

Additional context

No response

Charan167 commented 1 month ago

Hello @AriPerkkio. I was trying to recreate this issue but it seems to be working fine. Could you please help me out?

https://github.com/user-attachments/assets/924cf1a8-c0f2-4161-a268-cb8b4e9336e1

AriPerkkio commented 1 month ago

but it seems to be working fine

Great, thanks for checking this! 🙌

I'll check later if this issue is still valid. Feel free to proceed with the other issue mentioned in https://github.com/stackblitz/tutorialkit/pull/343#pullrequestreview-2322783870.

AriPerkkio commented 1 month ago

I'll check later if this issue is still valid.

Yup, this is still valid. Added failing test case at https://github.com/stackblitz/tutorialkit/tree/test/terminal-false.

Task assigned to @RonithManikonda.

tk-terminal-false.webm