search

stackblitz / webcontainer-core

Dev environments. In your web app.
https://webcontainers.io
MIT License
3.89k stars 160 forks source link

BUG: cls-hooked and AsyncLocalStorage not working #196

Open muxiangqiu opened 3 years ago

muxiangqiu commented 3 years ago

Describe the bug: cls-hooked not working.

Link to the blitz that caused the error: https://stackblitz.com/edit/node-zwyb6w?file=index.js https://stackblitz.com/edit/node-s1d4mv (about AsyncLocalStorage)

Steps to reproduce:

  1. Go to https://stackblitz.com/edit/node-zwyb6w?file=index.js
  2. node index.js
  3. See error

Expected behavior: I would expect the command to succeed without error(s)

Screenshots: image

Desktop (please complete the following information):

muxiangqiu commented 3 years ago

@EricSimons Can someone help me solve it？

SamVerschueren commented 3 years ago

Hi @muxiangqiu! I don't think we currently have anything implemented regarding async_hooks. Chiming in @d3lm as he might have a better view on this.

d3lm commented 3 years ago

Yes that's not implemented yet.

muxiangqiu commented 3 years ago

Got it! Thanks!

It would be great if webcontainer can support async_hooks .

d3lm commented 3 years ago

Yep for sure. We'll add this to our roadmap but we cannot promise any date when this will be ready. We'll keep you posted if there's updated on this. Thanks for your understanding 🙏

HeyGarrison commented 2 years ago

@d3lm It looks like we ended up getting in this enhancement? The project seems to run? 🤷

d3lm commented 2 years ago

Not sure if it's unrelated now to async_hooks but that is still unsupported for the time being.

muxiangqiu commented 2 years ago
image