Git URL dependency support

cherniavskii commented 2 years ago

Describe the bug

In MUI X repository we have a Git URL dependency: https://github.com/mui/mui-x/blob/next/package.json#L85

This makes dependency installation process fail:

❯ yarn install --verbose
verbose preInstall Validate "package.json"
warn preInstall No description field
warn preInstall No repository field
warn preInstall No license field
┌ [1/4] 🔍  Resolving dependencies
└ Completed in 26.882s
verbose Skipping audit
┌ [2/4] 🚚  Fetching dependencies
│ info pruneDeps Excluding 1 dependency. For more information use `--verbose`.
│ └─ node_modules/fsevents@2.3.2
└ 𐄂 Failed
HttpError: Failed to fetch dependencies:
- @mui/monorepo@5.10.9

error Command failed with exit code 1

Link to the blitz that caused the error

https://stackblitz.com/~/github.com/mui/mui-x

Steps to reproduce

Go to https://stackblitz.com/~/github.com/mui/mui-x
Install dependencies: yarn install --verbose

Expected behavior

Git URL dependencies are supported

Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots

No response

Platform

Version = 1.67.0
Hash = 35b869fee6c097380f8b2e33563ab4a16c08f57b
WebContainer = ea2f6b48b77806aba8e6fe3b6311530cc7674f64

Browser name  = Chrome
Full version  = 105.0.0.0
Major version = 105
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 139561726,
  "usedJSHeapSize": 113588398,
  "jsHeapSizeLimit": 4294705152
}

Additional context

No response

FossPrime commented 2 years ago

They implemented tarball dependency support a couple months ago https://stackblitz.com/edit/vitejs-vite-zfaynu?file=package.json

git support wasn't possible until their git-js CORS proxy was implemented in codeflow

d3lm commented 1 year ago

Hey 👋 Thanks for the report. turbo (our in-house package manager) currently doesn't support git dependencies. You could try to use yarn or pnpm instead which both support this type of dependency. However, for npm we are currently working on native support which will likely resolve this issue.

cherniavskii commented 1 year ago

Hi @d3lm We are actually using yarn. Please try this:

go to https://stackblitz.com/~/github.com/mui/mui-x
run yarn install --verbose

the installation process hangs, here are the logs:

~/mui/mui-x master 1s
❯ yarn install --verbose
yarn install v1.22.19
verbose 6.465 Checking for configuration file "/home/mui/mui-x/.npmrc".
verbose 6.465 Checking for configuration file "/home/.npmrc".
verbose 6.465 Found configuration file "/home/.npmrc".
verbose 6.465 Checking for configuration file "/usr/local/etc/npmrc".
verbose 6.465 Checking for configuration file "/home/mui/mui-x/.npmrc".
verbose 6.465 Checking for configuration file "/home/mui/.npmrc".
verbose 6.465 Checking for configuration file "/home/.npmrc".
verbose 6.465 Found configuration file "/home/.npmrc".
verbose 6.466 Checking for configuration file "/home/mui/mui-x/.yarnrc".
verbose 6.466 Found configuration file "/home/mui/mui-x/.yarnrc".
verbose 6.466 Checking for configuration file "/home/.yarnrc".
verbose 6.466 Checking for configuration file "/usr/local/etc/yarnrc".
verbose 6.466 Checking for configuration file "/home/mui/mui-x/.yarnrc".
verbose 6.466 Found configuration file "/home/mui/mui-x/.yarnrc".
verbose 6.467 Checking for configuration file "/home/mui/.yarnrc".
verbose 6.467 Checking for configuration file "/home/.yarnrc".
verbose 6.468 current time: 2023-03-20T20:17:52.140Z
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
verbose 6.772 Performing "GET" request to "https://t.staticblitz.com/w/v13/polyfills".
verbose 7.991 Request "https://t.staticblitz.com/w/v13/polyfills" finished with status code 200.
[#############################################################################################################################################################################################################] 1911/1911

It just stays like this and nothing happens.

stackblitz / webcontainer-core