stackblitz / webcontainer-core

Dev environments. In your web app.
https://webcontainers.io
MIT License
3.87k stars 157 forks source link

committing with codeflow (`pr.new`) doesn't use the noreply email #933

Open mayank99 opened 1 year ago

mayank99 commented 1 year ago

I was trying to submit a PR to a repo. I made my changes and committed them, but when pushing to a branch, I got this error:

To [redacted-repo-url].git
 ! [remote rejected] mayank99/patch-19647 -> mayank99/patch-19647 (push declined due to email privacy restrictions)
error: failed to push some refs to [redacted-repo-url].git

I tried changing the email explicitly using git config user.email mayank99@users.noreply.github.com in the stackblitz terminal but it didn't help.

I believe stackblitz should default to the noreply email, just like github's web UI and github.dev do.

See github docs: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/blocking-command-line-pushes-that-expose-your-personal-email-address

SamVerschueren commented 1 year ago

Hey @mayank99! Yes, you are right, we should take that setting into account. I'm wondering why the git config didn't work for you? I tried it myself and git log showed the following.

image

I created an internal ticket to track this. It's a very good point!

54145a commented 3 months ago

Same issue