search

stackblitz / webcontainer-docs

WebContainer API Documentation
MIT License
71 stars 23 forks source link

feat(tutorial): add steps for attaching a terminal #15

Closed SamVerschueren closed 1 year ago

SamVerschueren commented 1 year ago

This PR adds 2 additional steps to the tutorial on how to attach a terminal to the WebContainer processes.

I have some inline TODO comments to add screenshots. I can add them myself, but then they might not be in the same style as the others.

I might also add some small questions and comments in the PR itself.

@sylwiavargas feel free to rewrite portions of the docs without my consent.

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

netlify[bot] commented 1 year ago

Deploy Preview for webcontainer-docs ready!

Name Link
Latest commit 27626d7f250ab757e78f68054344872de29cbd06
Latest deploy log https://app.netlify.com/sites/webcontainer-docs/deploys/63f76711c664e40008c3b096
Deploy Preview https://deploy-preview-15--webcontainer-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sylwiavargas commented 1 year ago

Hey @SamVerschueren! I've edited these two pages, added the screenshots, and the og images. I will redo them in a near future so all of them look similar (and the images are small). We will also be changing the sidebar navigation items tomorrow so it's okay that they don't exactly follow the same pattern.

Most importantly, thank you for your work. sooooooo appreciated.