search

stackblitz / webcontainer-docs

WebContainer API Documentation
MIT License
67 stars 22 forks source link

Fix event name in Quickstart doc #35

Closed igoradamenko closed 1 year ago

igoradamenko commented 1 year ago

Hey there.

As far as I understand, there is no event called port-ready, only server-ready. server-ready is also used in the code example below the text I edited.

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

igoradamenko commented 1 year ago

Btw, there is a link “Edit this page” at the end of the doc:

image

The link leads to https://pr.new/stackblitz/webcontainer-docs/edit/main/docs/guides/quickstart.md?initialPath=/guides/quickstart. When I clicked this first time, it showed me the editor, but could not start the container properly. It failed on dependencies install phase. Could not find @types/gtag.js or something like this.

Then I logged in, but decided to fork & clone the repo locally, because it's faster than work with the container. Plus I thought I could fix the dep error. However, I could not reproduce the installation error locally.

So, when I created this PR, I decided to click on “Edit this page” once again, just to be sure that there is still that error. But now it asks me for more permissions:

image

And this is quite weird. Should it work this way? I already gave the app some permissions when I was logging in. Does it need more of them? 🤔

Not to say that I says it wants to get permissions to stackblitz/webcontainer-docs, but I probably do not have any specific permissions for this repo.

Edit: When I click on the purple-ish button “Review PR” from the previous comment, I get the same windows with permission requirement ¯\_(ツ)_/¯