chore: add property-based tests for Configuration.Dotenv.Parse

stackbuilders / dotenv-hs

Load environment variables from dotenv files for Haskell

https://hackage.haskell.org/package/dotenv

MIT License

65 stars 14 forks source link

chore: add property-based tests for Configuration.Dotenv.Parse #168

Closed flandrade closed 9 months ago

flandrade commented 1 year ago

This pull request focuses on improving the test suite for the module responsible for parsing files in the dotenv format. The primary enhancement involves replacing a subset of existing unit tests with property-based tests. These new tests leverage randomly generated strings, taking into account the following input characteristics:

Lines in the format of key=value
Support for comments and blank lines

Let me know your thoughts, @jpvillaisaza, @CristhianMotoche

CristhianMotoche commented 1 year ago

Hello @flandrade Did you have the chance go review the last comments? Do you need a hand to complete this?

CristhianMotoche commented 1 year ago

Hey @flandrade Do you need any help with this PR?

CristhianMotoche commented 9 months ago

Hey @flandrade I would love to get these new tests in our code base so I updated your changes a little bit and I plan to merge them very soon.

flandrade commented 9 months ago

@CristhianMotoche Hey, sorry, I had my notifications disabled. I'll address the comments by the end of the week.

CristhianMotoche commented 9 months ago

No worries @flandrade I updated the branch and I think it looks good! :shipit: