search

stackbuilders / hspec-golden

Golden tests with Hspec
MIT License
26 stars 8 forks source link

More flexible file locations #26

Closed bitc closed 3 years ago

bitc commented 3 years ago

This fixes #23 and #13

Removes the fields testName and directory and replaces them with goldenFile and actualFile. This allows a lot more flexibility:

This pull request has 2 commits. The first commit maintains the testName field, but I think things are cleaner and simpler without it (2nd commit).

The hgold program isn't aware of the changes made, but will still continue to work if you use defaultGolden (the default directory and file names).

christianwish commented 3 years ago

@bitc Hi! Thanks for this PR. Option to not save "actual" files This is the feature I am waiting for :)

@CristhianMotoche Can I do something to help you, merging this two commits?

CristhianMotoche commented 3 years ago

Hi @christianheyn The PR is good. I think I forgot to merge it. Thanks @bitc for the contribution. :tada: