search

stackcollision / GardenConquest

A new conquest game mode for Space Engineers
6 stars 7 forks source link

Implementing #99 #114

Closed HaoTNN closed 9 years ago

HaoTNN commented 9 years ago

Change some things around to make it possible as well. I kind of want to move the logic out of Core_Client, but up to you. Lemme know what you think.

zrisher commented 9 years ago

Per the above comments, would you please also add a check to GridEnforcer.reevaluateOwnership() for SimpleOwnership and just pass the classifier owner instead of of those of all blocks?

zrisher commented 9 years ago

Let's wait on moving things out of core client until I refactor it to use the new session components from SEGarden.

HaoTNN commented 9 years ago

Regarding the check to GridEnforcer.reevaluateOwnership():

I.e,

if (s_Settings.SimpleOwnership) {
    changed = m_Owner.reevaluateOwnership(new List<long> { m.Grid.getClassifierBlock().OwnerId });
}
else {
    changed = m_Owner.reevaluateOwnership(BigOwners);
}

Right?

zrisher commented 9 years ago

This has been merged and fixed up, but not released to public yet because I'm still getting some residual errors. Currently, if I create a grid as a player, switch to a faction, add/remove some blocks, and try to change classifier to one that requires a faction I get a "you're not in a faction" message.

zrisher commented 9 years ago

Fixed with #130, will test and then release.