Logic and usability

[zrisher]

This is an attempt at improving the usability of the mod by making its cleanup logic more intuitive and powerful. This closes #4, #5, #14, #20, and #26 and I think once we're satisfied with it we are in an excellent place to start our beta release. This also incorporates PR #55.

Format-wise, this is not completely up to the quality I want it to be before incorporating - there's a fair amount of logging and commented areas that I'll need to remove first, and probably some small spacing changes to do.

Functionally, it's running with no crashes consistently on my local machine and when I tested with Chickenbranches tonight (after some fixes). The only current bug I know of is that CPs are not currently distributing rewards - the FACGRID grouping returns zero. But that seems to be unrelated to my changes, and is ripe for a bit of refactoring using your new FactionFleet system.

So I'm submitting this as a WIP - please point out areas where you'd like to see things done differently, this will help me get it ready faster.

Here's a moderately-complete list of changes:

Features

• Added Station blocks, tested OK
• Fleet "Support" - FactionFleets now keep track of added GridEnforcers and decide whether to "Support" or "Unsupport" the grid if it's over the Max count set for that class/ownerType. This was necessary to allow more seamless handling of newly classified grids that might be over the limit, such as those produced by merges, newly modded worlds, rule changes, dynamic conceal, or simply changing classifiers. Instead of removing their classifier on init if it's greater than the count already stored, we add it to the fleet but compare its size against existing grids to choose the best targets for support. Unsupported grids receive Violations just like they do for other limits, which are handled by the GE.
• Multiple classifier support - Same reasoning as the above, instead of taking whatever classifier loads first and deleting the rest, we compare newly added classifiers with the stored one and take the highest class, leaving the others intact for eventual cleanup. This is handled with a Violation on the GE, same as other limits.
• Settings flexibility - Changed HullRules to HullRuleSets which store all class-based rules at a single point for easier consumption by Enforcer logic and greater flexibility of customization. This allows for per-class based capture rates, faction and player limits, and custom BlockTypes with case-insensitive partial subtype name matching
• Over-Time Violation "Cleanup" instead of Dereliction - all limits on grids for blocks that weren't able to be controlled on add are available as VIOLATIONs consumed by a single cleanup process. This process uses the Derelict timers to run timed checks on all Class-based limits, applying limits incrementally. Now we have two basic Violation systems - OnPlacement violations are passed a VIOLATION_TYPE. Over-time violations are held in VIOLATIONs that carry display details, counts, and metadata about the violation like BlockType.

Balance

• Updated Ship License costs to reflect turret and size changes, most things went down due to low turret difference between small Large Ships and the largest. Did not touch block count or block type count limits.

Bug Fixes

• Removed blocks now have their physics updated
• Derelict Timers always loaded as expired - fixed by removing TimerExpired = true from init, seems to flow correctly
• Derelict Timers would not reset their TimeRemaining when cancelled. This resulted in a confusing situation when you changed the cleanup timespan on a server, but old times would be loaded from stateeven for cancelled timers
• Mod Load Errors - Added Blueprint for Ship License. Included <Enabled>False</Enabled> attribute so it shouldn't be buildable, tested ok
• Added check for

Code Features

• Added HullClassifier helper object for hull classifier logic and data
• Added DEST_TYPE.NONE for more seamless handling of message states that may not have an audience
• Added SecondsRemaining property on timers to make notifications easier
• Made the FactionFleet.debugPrint method spit out a lot more info. It's pretty nicely formatted and won't show extraneous info, but understand if you want to nix this one
• Helpers to avoid checking for null events when raising in GE

To Do These are things I just need to make issues for after beta release but I haven't yet:

• Find a way to re-use timers instead of throwing away and starting new ones? Somehow build the phase ticking into timers to get many ticks over a period of time? But how would you get to "expired" each time? Would it even be worth the additional complexity?
• Remove type counts from notifications, get fleet view dialog working, and put in a reminder on the chat dialog command
• Allow players to Disown - aka change ownership of all THEIR blocks to no one - any of their grids
• Enforce static grid for station block classification
• Increase component costs for better classifiers?
• Increase build time for classifiers depending on weighted total components
• Custom Block models, bigger sizes for larger classifiers
• Increase class counts and diversity?

[zrisher]

Fixed the bug with CPs, seem to be working.

[zrisher]

I think formatting is mostly up to snuff now too, removing WIP tag. Please let me know if you see places that should be amended.

[zrisher]

Added some updates to grid ownership and fleet tracking.

Fixed Bugs

• reevaluateOwnership doesn't catch if they were a player and are now a faction, same with faction, and doesn't check often/early enough
• Closed grids did not update their owner, fleet, and statetracker appropriately
• Merging failed to take the highest classifier and deleted both grids - seems fixed by ownership updates http://pastebin.com/6FNSavkA

[zrisher]

Further updates:

Fixed Bugs

• Unmerged grids that lose their classifier now look for any other classifiers they have and apply the best
• Settings file now does not crash on write if APIGateway is missing
• Settings load now loads defaults for any missing data even on an otherwise successful load

Features

• Cleanup/derelict timers now update their time remaining if the server's timer length setting changes. They take the ratio of new length / old and multiply it by current time remaining.
• You can now list your fleet in a dialog with "/gc fleet". Huzzah!
• You can now list your current violations with "/gc violations"!

[zrisher]

This also mostly fixes #33