search

stacked-git / stgit

Stacked Git
https://stacked-git.github.io/
GNU General Public License v2.0
535 stars 61 forks source link

stg mail send with multiple --cc options only honors the first #460

Closed chaudron closed 4 months ago

chaudron commented 5 months ago

When I use the following command:

stg email send --to dev@openvswitch.org --annotate ./patch --cc aaaa@ovn.org --cc bbb@redhat.com --cc ccc@redhat.com

Only the first --cc is included in the sent email.

jpgrayson commented 4 months ago

Hi @chaudron. Thanks for writing this up.

However, am not able to reproduce this issue. I modified an existing test case in t1903-email-send.sh to add several --cc options and I am able to observe all of them in the Cc: header.

The tests I ran use --dry-run. I wonder if that might be making a difference?

I also wonder what version of git you were running? I tested with the latest 2.45.2.

stg email send is just a thin wrapper on git send-email, so I'm not sure what StGit could do to cause this kind of breakage. If you run git send-email directly, does the problem still occur?

chaudron commented 4 months ago

I tried to replicate this again on my setup using some private addresses, and it works fine :( I'll close this for now and, re-test later when sending patches to a mailing list. If it fails again, I'll re-open.