Closed ekzyis closed 2 months ago
The recent updates across several components focus on enhancing user-specific data handling and security. Changes include the introduction of dynamic database and storage key configurations based on user information, the migration of local storage items for better data isolation, and improved logout procedures that clear user-specific configurations, addressing concerns about shared local storage in a multi-user environment.
File Path | Change Summary |
---|---|
components/logger.js |
Added dynamic database naming based on user info for IndexedDB initialization. |
components/nav/... |
Enhanced logout functionality and moved logic to new LogoutDropdownItem component. |
components/webln/... |
Introduced functions for migrating local storage and clearing configurations, and updated storage key handling based on user info. |
Objective | Addressed | Explanation |
---|---|---|
Clear local storage on logout to prevent data sharing [#927] | ✅ | |
Ensure user-specific local storage to prevent cross-account data access [#927] | ✅ |
The changes made in the code effectively address the issue of shared local storage in a shared browser by implementing user-specific storage management and ensuring that local storage is cleared upon logout, thereby enhancing security and data isolation for users.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
looks good. Just need to resolve merge conflicts
Done
Description
Close #927
TODO:
Additional Context
Checklist
Are your changes backwards compatible? Please answer below:
Yes, stackers will still be able to access their current attached wallets without attaching them again. If a wallet wasn't found with the new key, we will fallback to the old key and migrate it to the new key.
Did you QA this? Could we deploy this straight to production? Please answer below:
Yes, but I couldn't test LNC since I don't know how to connect it. See https://github.com/stackernews/stacker.news/pull/1104#discussion_r1582239915.
For frontend changes: Tested on mobile? Please answer below:
Did you introduce any new environment variables? If so, call them out explicitly here: