search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
404 stars 105 forks source link

Force post options open when dirty or on errors #1129

Closed benalleng closed 1 month ago

benalleng commented 2 months ago

Description

Closes #1045, closes #491

This will force the options tab open on post render if the inputs are dirty or opens them on submit if the options contain errors

Screenshots

Additional Context

I designed it such that it should only be forced open when the advpostform contains errors. It will also start opened if the form is dirty at all, errors or not

If the options starts open because it is dirty or fills in the form with some valid inputs and then closes it, it will not reopen

Checklist

Are your changes backwards compatible? Please answer below:

Did you QA this? Could we deploy this straight to production? Please answer below:

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough The recent updates focus on enhancing form and component visibility and state management in various components. These changes introduce `useState` and `useEffect` hooks for better handling of form states and user interactions, improving the dynamic behavior of forms and buttons within the application. ## Changes | Files | Summary | |-------|---------| | `components/accordian-item.js`, `components/adv-post-form.js`, `components/bounty-form.js`, `components/discussion-form.js`, `components/job-form.js`, `components/link-form.js`, `components/poll-form.js` | Enhanced form and component visibility and state management using `useState` and `useEffect`. Added `handleClick` functions to manage visibility based on user interactions. | | `components/fee-button.js`, `components/post.js` | Updated to include new `onClick` handlers for state toggling and enhanced interaction handling. | | `components/form.js` | Introduced additional parameters for error handling and state tracking in form inputs. | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------|-----------|-------------| | Automatically unroll options section if prepopulated [#1045] | ❓ | It's unclear if the changes directly address the automatic unrolling of sections when prepopulated. This specific behavior needs confirmation. | | Delete prepopulated context on title and link deletion [#1045] | ❌ | The changes do not indicate automatic clearing of prepopulated contexts when title and link entries are deleted. | | Provide feedback for errors in collapsed options [#491] | ❌ | There are no modifications to ensure error messages are displayed when options are collapsed. | | Display error messages correctly below fields [#491] | ❓ | While the changes mention error handling in forms, it's unclear if this specifically addresses the correct display of error messages as required. |
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 23577d3ffa26347286e50b72b9ba95adbced2e95 and a892683d2d6568e379cc982944e710bcf8febd9d.
Files selected for processing (7) * components/accordian-item.js (2 hunks) * components/adv-post-form.js (3 hunks) * components/bounty-form.js (3 hunks) * components/discussion-form.js (3 hunks) * components/job-form.js (3 hunks) * components/link-form.js (3 hunks) * components/poll-form.js (3 hunks)
Files skipped from review due to trivial changes (1) * components/poll-form.js
Files skipped from review as they are similar to previous changes (6) * components/accordian-item.js * components/adv-post-form.js * components/bounty-form.js * components/discussion-form.js * components/job-form.js * components/link-form.js
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
huumn commented 1 month ago

This does its job and fixes the bug. I didn't love the use of a ternary show ... I thought it was confusing so I removed it.

Note to myself: This whole accordion and localstorage draft thing needs a zoomed out refactor because it's a big hack. We keep tacking stuff onto our existing forms but the design of those were unconscious of all the things we'd add.