stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
404 stars 105 forks source link

remove leaky text in uploadMarker #1130

Closed itsrealfake closed 2 months ago

itsrealfake commented 2 months ago

Description

closes #1096

Screenshots

Additional Context

Checklist

Are your changes backwards compatible? Please answer below:

Did you QA this? Could we deploy this straight to production? Please answer below:

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The change addresses a privacy concern by modifying how image alt attributes are handled during the image upload process in a markdown input component. Instead of using the original filename, which could leak sensitive data, the alt text is now left blank, enhancing user privacy. ## Changes | File Path | Change Summary | |-----------|----------------| | `components/form.js` | Updated the replacement text in the `MarkdownInput` function from `![Uploading ${name}…]()` to `![](${url})`. | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------|-----------|-------------| | Overwrite filename with random string or delete string for image alt attribute (#1096) | ❌ | The change does not implement a random string or deletion; it leaves the alt attribute blank. | | Ensure unique identifiers are maintained for `onSuccess` callback functionality (#1096) | ✅ | | | Avoid user confusion by changing file names on upload (#1096) | ✅ | | | Parse for image alt attributes on client or server to identify which should be replaced (#1096) | ❓ | The change does not explicitly mention parsing alt attributes to differentiate between user-provided and system-replaced ones. | | Limit replacement to images from specific domains (#1096) | ❓ | The provided change summary does not clarify whether the replacement is limited to images from `m.stacker.news`. |

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between df631878e0e586b83e9fd98be1854f2ec59b96d7 and 9c32d0fbf0569fce439d9ee28fcc0954807d28c7.
Files selected for processing (1) * components/form.js (1 hunks)
Files skipped from review due to trivial changes (1) * components/form.js
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
itsrealfake commented 2 months ago

Works great!

Swag. How does this get merged?

huumn commented 2 months ago

I merge it when I'm in a reviewing/merging/award data entry mood.

itsrealfake commented 1 month ago

while writing a comment which took advantage of this, i had a thought about a feature

when the user uploads their first image, a UX like

1. Logged user uploads from clipboard w/ e.g. CMD+V

2. Popup to save preference option

"we automatically strip EXIF data & file names when you upload an image.

would you like stacker.news to leave a link when paste images into a comment box?

[ ] do nothing [ ] show you an option dialogue to create a link to source

You can change this later in preferences.

3. Show a dialogue to optionally leave a link to source w/ pasted image.

Would you like to add a link to the image source? You can change this option in user preferences.

ekzyis commented 1 month ago

What do you mean with "link" here?

would you like stacker.news to leave a link when paste images into a comment box?