search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
424 stars 106 forks source link

Force HTTP over Tor for CLNRest #1133

Closed ekzyis closed 5 months ago

ekzyis commented 5 months ago

Description

~I looked into proxy-agents as mentioned in https://github.com/stackernews/stacker.news/issues/1107#issuecomment-2086090010 but I realized HttpsProxyAgent does not support https.Agent options (see https://github.com/TooTallNate/proxy-agents/issues/234 and https://github.com/TooTallNate/proxy-agents/issues/243). So the naming is confusing since it uses http.Agent under the hood. So we can't use it to configure CA certificates.~

~I decided that for now, we can support Tor over HTTP.~

Close #1107

Updated by copying proxy agents from hpagent.

This should now work for HTTPS over clearnet (as already did) and HTTP(s) over Tor.

TODO:

Screenshots

no screenshots because I still need to configure screenshotting on my laptop

Additional Context

For some reason, I get ETIMEDOUT instead of ENOTFOUND now:

2m [cln] ERROR could not connect to CLN: request to http://stacker_cln.onion:3010/v1/invoice failed, reason: connect ETIMEDOUT 143.244.XXX.XXX:3010 2m [cln] ERROR failed to attach wallet

Checklist

Are your changes backwards compatible? Please answer below:

Did you QA this? Could we deploy this straight to production? Please answer below:

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

coderabbitai[bot] commented 5 months ago
Walkthrough ## Walkthrough The update focuses on enhancing the `createInvoice` function within `lib/cln.js` to better support Tor connectivity by adjusting URL schemes and HTTPS agent creation based on the socket address and certificate presence. This aims to resolve issues with connecting to `.onion` addresses and improve security and functionality. ## Changes | File | Change Summary | |----------------|----------------| | `lib/cln.js` | Adjusted URL scheme based on socket address, added HTTPS agent creation based on certificate presence, and modified URL construction. | | `pages/settings/wallets/cln.js` | Updated the `label` prop of an `Input` component in the `CLN` component to include information about using CLNRest over HTTP when using Tor. | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------|-----------|-------------| | Connect CLN node using clnrest for withdrawal over Tor (#1107) | ✅ | | | Correctly handle `.onion` addresses to prevent hostname resolution errors (#1107) | ✅ | | | Ensure secure connection when certificates are provided (#1107) | ✅ | | The changes made in the PR address the main concerns raised in the linked issue about connecting to CLN nodes over Tor, handling `.onion` addresses correctly, and ensuring secure connections when certificates are available.
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 2441804b043c68a7960b6a62a87f3c8d8f7e928d and c324072ec74c99aae516fdb674848d1fc380646a.
Files selected for processing (1) * pages/settings/wallets/cln.js (1 hunks)
Files skipped from review due to trivial changes (1) * pages/settings/wallets/cln.js
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.