search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
404 stars 105 forks source link

Add Footer to User Page #1135

Closed itsrealfake closed 2 months ago

itsrealfake commented 2 months ago

this closes #1016

Description

Shows a Footer on the User Page when the user has a bio but shows no Footer when user bio is absent.

Screenshots

Skinny screen:

image

Thick screen:

image

Hidden when there's no bio:

image

Additional Context

Checklist

Are your changes backwards compatible? Please answer below:

yes

` **Did you QA this? Could we deploy this straight to production? Please answer below:**

yes

For frontend changes: Tested on mobile? Please answer below:

Tested with mobile emulation in browser

coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The update involves enhancing the user profile pages by including the `Footer` component conditionally based on the presence of `user.bio`. This change ensures that the common page footer is now visible on these pages, addressing the issue reported. ## Changes | File | Change Summary | |--------------------------|--------------------------------------------------------| | `pages/[name]/index.js` | Import `Footer` component and conditionally render based on `user.bio`. | | `styles/user.module.css` | Added padding to the `display: flex;` rule. | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------------------------------------------------|-----------|-----------------------------------------------| | User Profile pages should display the common footer (#1016) | ✅ | |
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between ab2c378f798b62ddd86d219cae92563c77e564ff and 00f941e8ff155644d94829346500e0c21dd735e1.
Files selected for processing (2) * pages/[name]/index.js (1 hunks) * styles/user.module.css (1 hunks)
Files skipped from review due to trivial changes (1) * styles/user.module.css
Files skipped from review as they are similar to previous changes (1) * pages/[name]/index.js
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
itsrealfake commented 2 months ago

this branch should have been 1016-... my eyeball copy-pasta game is weak af.

benalleng commented 2 months ago

I think that it still doesn't look great when the user's profile is sparse, especially in the mobile view you showed. while their bio isn't empty it certainly feels like the footer takes up way too much space, even though you did scroll down to it.

I will again suggest that we try the footer like /404 as it is kind of a footer-lite and isn't quite as obtrusive on pages like this that may frequently be empty or sparse without necessesarily having the logic to show or not show when the bio is empty

itsrealfake commented 1 month ago

thanks for the feedback & resolution @benalleng + @huumn