search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
424 stars 106 forks source link

Add explicit word break for items #1137

Closed benalleng closed 5 months ago

benalleng commented 5 months ago

Description

Closes #1125 adds an explicit word break to the main and other item components to handle the text of long titles. Firefox handles this break by default but it seems that chrome and safari do not

Screenshots

chrome linebreak (note the break-all behavior in the url where the rest of the title has break-word) image

firefox linebreak (no change from prod) image

Additional Context

This bit of css seems to only be necessary for chrome or safari based browsers as firefox seems to already have some default line-breaks built for slash characters. however, since I cannot explicitly state to make a linebreak on a "/" I opted to add word-break: break-word; instead. as a result the word breaks on firefox <-> chrome look slightly different

Checklist

Are your changes backwards compatible? Please answer below:

Yaaasss

Did you QA this? Could we deploy this straight to production? Please answer below:

Yaaasss

For frontend changes: Tested on mobile? Please answer below:

Tested in firefox and chrome, not on safari

coderabbitai[bot] commented 5 months ago
Walkthrough ## Walkthrough The update in the codebase primarily aims to prevent horizontal overflow in mobile notifications by implementing CSS word-breaking for post titles with unusually long words. This change enhances the user interface by ensuring that long words in notifications do not extend beyond the screen width. ## Changes | File Path | Change Summary | |---------------------------|-------------------------------------------------| | `components/.../item.module.css` | Added `word-break: break-word;` to `.a.link:visited` and `.main` classes | ## Assessment against linked issues | Objective | Addressed | Explanation | |---------------------------------------------------------------------------|-----------|-------------| | Notifications with post titles without word breaks overflow horizontally (#1125) | ✅ | |
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between fd2008e5d1a2a8521a330a097b5aaf51bba6ce3d and 605d28ca294112d3085b2359923dedacb44f315f.
Files selected for processing (1) * components/item.module.css (2 hunks)
Additional comments not posted (2)
components/item.module.css (2)
`93-93`: The addition of `word-break: break-word;` to the `.other` class is a suitable fix for preventing text overflow on mobile devices. --- `160-160`: The addition of `word-break: break-word;` to the `.main` class effectively addresses the overflow issue, enhancing the user experience on mobile devices.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.