Item popover - Githubissues

felipebueno commented 4 months ago

Description

Just like the User Popover but for items. The motivation was the same, to have a little bit more information about an item without having to navigate to the item.

More info here: https://stacker.news/items/530617

Screenshots

Checklist

Are your changes backwards compatible? Please answer below:

Yes

Did you QA this? Could we deploy this straight to production? Please answer below:

Not yet

For frontend changes: Tested on mobile? Please answer below:

It's a desktop only feature

Did you introduce any new environment variables? If so, call them out explicitly here:

No

TODO

[x] Introduce HoverablePopover and refactor UserPopover and ItemPopover to use it

coderabbitai[bot] commented 4 months ago

Walkthrough

## Walkthrough The recent updates enhance UI interactivity and styling with the introduction of new React components like `HoverablePopover` for hover-triggered popovers, `ItemPopover` for displaying item details, and `ItemSummary` for encapsulating item summaries. These changes also include the addition of new CSS modules for styling components, along with updates to manage click events and conditional rendering within the application. ## Changes | File Path | Change Summary | |------------------------------------------|---------------------------------------------------------------------------------------------------------------| | `components/hoverable-popover.js` | Introduced `HoverablePopover` component with hover-triggered popover functionality. | | `components/hoverable-popover.module.css`| Added styles for hoverable popovers, including border and font adjustments. | | `components/item-popover.js` | Introduced `ItemPopover` component for fetching and displaying item details in a popover. | | `components/item.js` | Added `onItemClick` function for handling item click events and `ItemSummary` component for item summaries. | | `components/item-info.js` | Added `showActionDropdown` and `showUser` props to control visibility of action dropdown and user info. | | `components/item-popover.module.css` | Added styles for `ItemPopover`, including border, font weight, and size adjustments. | | `components/item.module.css` | Introduced `.summaryText` class for handling text overflow in item summaries. | | `components/text.js` | Integrated `ItemPopover` into the `Text` component's rendering logic. | | `components/user-popover.js` | Replaced `react-bootstrap` components with custom `HoverablePopover` and `ItemPopover` components. |

Recent Review Details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 5d7c74252271010f220dc019bb0be3fda4c39bfc and 115bc1b26491426f50466fb422759eb02fa4bd40.

Files selected for processing (3)

* components/hoverable-popover.js (1 hunks) * components/item-popover.js (1 hunks) * components/item.js (5 hunks)

Files skipped from review as they are similar to previous changes (3)

* components/hoverable-popover.js * components/item-popover.js * components/item.js

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

felipebueno commented 4 months ago

if the item is a comment, this just displays ItemInfo which is weird

Oh, I forgot to test it with comment links

this makes me curious how this handles #/related and other such links

Good question

I'll test it and work on the fixes today

felipebueno commented 4 months ago

if the item is a comment, this just displays ItemInfo which is weird

@huumn what do you think of these solutions?

Max two lines for the title/text on ItemSummary

Fix paddings

For when there's no title:

felipebueno commented 4 months ago

this makes me curious how this handles #/related and other such links

Can you give me examples of such links? I tried #<item number>/related but it throws 404

huumn commented 4 months ago

@huumn what do you think of these solutions?

Looks great. If it's not a huge lift, can we make the comment look more like a comment? e.g. ItemInfo on top and text not bold?

Can you give me examples of such links? I tried #/related but it throws 404

This is the type of link: https://stacker.news/items/538496/related It's rendered like: #538496/related

felipebueno commented 4 months ago

If it's not a huge lift, can we make the comment look more like a comment?

Sure can, no problem :)

This is the type of link: https://stacker.news/items/538496/related

Hmm for some reason, those related links are not working in development. It probably has something to do with the related posts not being loaded... the skeleton never finishes loading