search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
404 stars 105 forks source link

Ticker in Sticky Header Does Not Inherit Changes #1196

Open sfr0xyz opened 1 month ago

sfr0xyz commented 1 month ago

Description

A change to the ticker in the header does not take effect on the sticky header when scrolling down.

Steps to Reproduce

  1. Change the display value of the ticker.
  2. Scroll down until the header becomes sticky.
  3. Compare the "sticky" and "non-sticky" ticker values.

Expected behavior

Expected "sticky" and "non-sticky" tickers to be the same.

Screenshots

  1. Initial "non-sticky" ticker: 1sat=1sat

non-sticky_initial

  1. Changed "non-sticky" ticker: 845397

non-sticky_changed

  1. "Sticky" ticker after change: 1sat=1sat (expected 845397)

sticky_after_change

huumn commented 1 month ago

Hint: the problem here is that we store the price carousel setting in localstorage and it's not reactive.