search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
403 stars 105 forks source link

Biopage userheader popover #1198

Closed kravhen closed 1 month ago

kravhen commented 1 month ago

Description

Wrapped the for "user.since" with to replicate the mouseover behavior on other pages.

closes #1180

Screenshots

image

Checklist

Are your changes backwards compatible? Please answer below:

Yes. Minor fix; no new component created.

Did you QA this? Could we deploy this straight to production? Please answer below:

Yes. Works as expected.

For frontend changes: Tested on mobile? Please answer below:

Yes.

Did you introduce any new environment variables? If so, call them out explicitly here:

No.

huumn commented 1 month ago

Nice work. Next time run sndev lint or install plugin in your editor for https://standardjs.com/.

Do you have a lightning address I can send the award to?

kravhen commented 1 month ago

Nice work. Next time run sndev lint or install plugin in your editor for https://standardjs.com/.

Do you have a lightning address I can send the award to?

Roger that. For educational purposes and in the future, would running the Git Actions locally (via act) have achieved the same (one of the actions seems to run eslint, which im guessing sndev does too)?

LNURL is nichro[at]getalby.com

Thank you and cheers!

huumn commented 1 month ago

would running the Git Actions locally (via act) have achieved the same (one of the actions seems to run eslint, which im guessing sndev does too)?

Yes. You can also do npm run lint.