search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
403 stars 105 forks source link

Allow API key access by default #1205

Closed ekzyis closed 1 month ago

ekzyis commented 1 month ago

Description

This PR updates every user to allow them API key access by default. The info was also updated to mention that this access can be disabled at any time.

Motivation for this is to allow anyone to build on SN without having to ask for permission in ~meta. API key access was disabled by default in #915 to limit our exposure to this new auth method. With #980 and #989 in place and after having gauged initial interest, I think it's safe to remove this requirement now.

Additionally, any item created with API keys will now be marked as bot.

Screenshots

2024-05-29-025646_594x85_scrot

Checklist

Are your changes backwards compatible? Please answer below:

Yes

Did you QA this? Could we deploy this straight to production? Please answer below:

Yes

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

ekzyis commented 1 month ago

Closing because we currently have different priorities and not the resources to deal with any potential downfall of this.

For the same reasons, we're not going to allow any more API keys for the moment.

We discussed that having additional filters like #690 would give us more confidence in allowing general API access.

ekzyis commented 1 month ago

@huumn, I think we can cherry-pick 71db5e87819fa20180a0b1bf8e10247ba7196391 and 6459295e49f6de2fac014dd3bbee37f79f1b4a73 from this branch. What do you think?

huumn commented 4 weeks ago

Yes I agree!