Close related section - Githubissues

stackernews / stacker.news

Internet communities that pay you Bitcoin

https://stacker.news

MIT License

403 stars 105 forks source link

Close related section #1207

Closed tsmith123 closed 4 weeks ago

tsmith123 commented 1 month ago

Fixes #837

Description

This PR ensures that the Related Posts section is closed once a comment is made.

This issue took me a while to find but eventually found the problem within Accordion component.

Made use of activeKey and onSelect props
Implemented onSelect handler to update activeKey value
Set activeKey value on load
Use null instead of undefined (Accordion doesn't seem to behave when using undefined)

Video

https://github.com/stackernews/stacker.news/assets/7639854/cf6cb2a3-29fc-4428-848b-1889ceead087

Testing

Please QA this if possible as I may have overlooked something.

tsmith123 commented 4 weeks ago

Thanks @ekzyis - good spot on the conditional. I've put that back. My testing was done with the proper conditional btw.