search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
403 stars 105 forks source link

Fix missing commentId parsing for item mentions #1219

Closed ekzyis closed 3 weeks ago

ekzyis commented 3 weeks ago

Description

The code for item mentions in the backend didn't parse internal links properly. Links like https://stacker.news/items/560297?commentId=561109 didn't use the comment id but the item id.

Item mentions should always use the id the frontend would show for the link when parsed.

Additional Context

Going to test the code for item mentions more since there might be more wrong

Checklist

Are your changes backwards compatible? Please answer below:

Yes

Did you QA this? Could we deploy this straight to production? Please answer below:

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

ekzyis commented 3 weeks ago

Going to test the code for item mentions more since there might be more wrong

Will put this out of draft. Will create another PR with a fix if I find another bug