search

stackernews / stacker.news

Internet communities that pay you Bitcoin
https://stacker.news
MIT License
403 stars 105 forks source link

Avoid manual optimistic updates for now #1220

Closed ekzyis closed 3 weeks ago

ekzyis commented 3 weeks ago

Description

Related to #1218

Manual optimistic updates break cache updates for comments (probably updates for all following mutations). This PR comments out the code that breaks them for now.

TODO:

Checklist

Are your changes backwards compatible? Please answer below:

Yes

Did you QA this? Could we deploy this straight to production? Please answer below:

Yes, tested zaps and custom zap with commenting afterwards, bounty payments, polls

For frontend changes: Tested on mobile? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

ekzyis commented 3 weeks ago

I kept the broken optimistic code for zaps as comments so I can easier study it. But it's probably better to completely focus on #1195 instead of trying to fix code that #1195 will make obsolete anyway.