search

stackery / php-lambda-layer

PHP Runtime Layer for AWS Lambda
Other
320 stars 70 forks source link

[PHP 7.3] fixed issue with installing remi repo and added missing PHP extensions #39

Closed titomiguelcosta closed 5 years ago

titomiguelcosta commented 5 years ago

This PR, fixes issue #38

In the end, it was a small fix. When building the php73.zip there were errors in installing remi repo, and it all came down to the order we installed epel and remi, reverting those instructions fixed the problem.

In term of adding the missing extensions required by Symfony 4, I only had to add php-xml and php-process to the list of php packages to be installed.

I tested and deployed the generated layer. phpinfo can be seen here (this page will be deleted once we merge this PR).

Side note: I did not explore, but I wonder why do we need to install httpd as part of building the image?! In my case, I'm using API Gateway to handle the requests and fire the lambda. I might be missing something but I do not think we need apache.

titomiguelcosta commented 5 years ago

To test my PR, just change to my branch and run $ make php73.zip Done on a Linux Mint 19.1 box with docker 18.09.6, build 481bc77

titomiguelcosta commented 5 years ago

This looks good to me! Can you also update the readme with the additional extensions this provides in the runtime layer?

@txase sure thing, done. copied the output of the command and put on the README sorted alphabetically

txase commented 5 years ago

Thanks!

I’ll look to update the layer in AWS early next week!

ronald2wing commented 3 years ago

xmlreader still missing