search

stackgl / contributing

Contribution guidelines for stackgl projects
Other
14 stars 3 forks source link

gl-texture-cube #5

Open hughsk opened 9 years ago

hughsk commented 9 years ago

Likely tricky as gl-texture2d has to cover a lot of ground, but this would be super useful for enabling skyboxes (#4) and reflection/refraction among other things :)

wwwtyro commented 8 years ago

I've got a first draft of this here: github/npm.

It's based heavily on gl-texture2d. So heavily, in fact, that I'm not sure we'll want to keep them separate going forward - there's a lot of duplicated code. Up to you guys!

It's very bare-bones right now - all it does is create cube textures from DOM elements, not empty ones or from ndarrays. I'll probably add stuff as I need it or you guys ask me to. :)

hughsk commented 8 years ago

This looks great so far! I'm leaning more to keeping it separate for simplicity's sake, but that's more @mikolalysenko's area :)

p.s. I've been meaning to ask, would you like us to add you to the stackgl org on github/npm? :D

wwwtyro commented 8 years ago

Thanks! I'm in agreement regarding keeping it separate. Maybe there's a clean way to separate the shared stuff into a gl-texture package.

As far as making me official goes... That. Would. Be. AWESOME! :D

hughsk commented 8 years ago

Sweet! You've been doing great stuff lately :grin: I'll do that now :)

wwwtyro commented 8 years ago

:tada: :tada: :tada: :tada: :smile: