search

stackgl / packages

:package: A list of packages that fall under the stack.gl umbrella
http://stack.gl/packages/
115 stars 11 forks source link

npm install and npm start not idempotent? #17

Closed rreusser closed 4 years ago

rreusser commented 8 years ago

It seems like building or starting the server fails if I don't rm -rf dist before installing or starting (except for the package data json; I can keep that). It's possible this is my scijs specialization, but I don't think I've changed anything substantial there. Is it possible it just fails if cpr is asked to overwrite files?

/Users/rreusser/projects/node/scijs/packages/build-make.js:13
  if (err) throw err
           ^

Error: Unable to copy directory entirely
  at /Users/rreusser/projects/node/scijs/packages/node_modules/cpr/lib/index.js:274:39
  at check (/Users/rreusser/projects/node/scijs/packages/node_modules/cpr/lib/index.js:169:17)
  at copy (/Users/rreusser/projects/node/scijs/packages/node_modules/cpr/lib/index.js:177:24)
  at doNTCallback0 (node.js:419:9)
  at process._tickCallback (node.js:348:13)
hughsk commented 8 years ago

Ah strange! Only seems to be an issue with a more recent version of cpr to what I had installed — keeping it at exactly 0.4.1 seems to do the trick though: https://github.com/stackgl/packages/commit/e14f706723407ecb3ca94a48eac40b5ed4df4805 Let me know if that fixes it for you?

rreusser commented 8 years ago

Yup, that fixed it just fine. Note to self: check if default overwrite option behavior changed, i.e. if setting that flag explicitly fixes it with the new version.

kevzettler commented 4 years ago

can this be closed?