search

stackgl / shader-school

:mortar_board: A workshopper for GLSL shaders and graphics programming
Other
4.28k stars 254 forks source link

No negative diffuse shading #143

Closed tschundler closed 8 years ago

tschundler commented 8 years ago

The clamping on the lambert factor from the previous exercise (https://github.com/stackgl/shader-school/blob/master/exercises/light-2/shaders/fragment.glsl) wasn't done in this one.

(as a side effect, there's no way I could have passed without cheating - both outputs look pretty similar)

tschundler commented 8 years ago

Seems this applies to the subsequent shaders too

mikolalysenko commented 8 years ago

Thanks, if you patch the other shaders I'll merge that in too.