search

stackgl / shader-school

:mortar_board: A workshopper for GLSL shaders and graphics programming
Other
4.28k stars 252 forks source link

exercise 02: note about radians #94

Closed yoshuawuyts closed 9 years ago

yoshuawuyts commented 9 years ago

Hey!

I just ran through exercise 02 (calculate the side lengths) and it was pretty tricky because I didn't know I had to convert degrees -> radians. It might be nice to slide in a small note that the sin and cos functions take radians as an arg, since it isn't apparent from High Quality Online Resources that you should do this.

yoshuawuyts commented 9 years ago

I just saw in exercise_03 that there's a hint section. Maybe a similar section about which functions take radians could be shown (because most functions do that, right?)

Jks15063 commented 9 years ago

wow I was banging my head against the wall trying to figure out why it wasn't working, thank you.

yoshuawuyts commented 9 years ago

@Jks15063 hah, no problem. I talked to @hughsk about it today, according to him the docs will probably be updated soonish. If you run into any other problems feel free to open up issues about it, I'm pretty sure the maintainers will be glad to have all the feedback they can get.

evillemez commented 9 years ago

Yeah, thanks so much for the heads up. I suck at math, but I was pretty sure I was doing this one right... was driving me a little nuts. :)