stackhpc / ansible-collection-cephadm

Apache License 2.0
16 stars 11 forks source link

Pull ceph images with tag after docker login #143

Closed technowhizz closed 3 months ago

technowhizz commented 6 months ago

Needs to merge after #142

In some environments issues are observed with images having missing tags and this missing tag causing cephadm shell to resort to using the default image. By pulling the ceph image to a host with the correct tag cephadm shell should be able be able to detect the image and use it.

The reason for this is that when an image doesnt have a tag, running docker images --format "{{.Digest}}" returns nothing and in the cephadm script there is a check to see if the Digest was printed or not. If it wasn't detected then it uses the default image

cityofships commented 3 months ago

In some environments issues are observed with images having missing tags and this missing tag causing cephadm shell to resort to using the default image. By pulling the ceph image to a host with the correct tag cephadm shell should be able be able to detect the image and use it.

The reason for this is that when an image doesnt have a tag, running docker images --format "{{.Digest}}" returns nothing and in the cephadm script there is a check to see if the Digest was printed or not. If it wasn't detected then it uses the default image

That's probably a bug on cephadm side of things and should be (at least) reported (found?) there. Meanwhile this PR feels like a sufficient workaround, suggested also for SES: https://www.suse.com/support/kb/doc/?id=000019923