Role idempotence

[Tcharl]

Hi folks,

This role rocks, thank you so much!

I made some little molecule tests over it: I can PR if you want to: https://github.com/OsgiliathEnterprise/ansible-virtualization

However, molecule is telling me that this role is not really idempotent (replace tcharl by yours, it's just a wrapper):

• [Fedora-Molecule-Virtualization] => tcharl.ansible_role_libvirt_host : Ensure the libvirt daemon is started and enabled
• [Fedora-Molecule-Virtualization] => tcharl.ansible_role_libvirt_host : Ensure libvirt storage pools are active
• [Fedora-Molecule-Virtualization] => tcharl.ansible_role_libvirt_host : Ensure libvirt networks are active

Do you want me to investigate? PR the tests and CI? Will you review (and potentially merge it) or should I maintain my fork? Best regards,

[markgoddard]

Hi Charlie. We would love some molecule tests. If they have found an issue that needs addressing, then even better.

[Tcharl]

Here they are !32 . You'll notice that I disabled "idempotence" tests: I'll try to fix them but not sure I'll succeed

[Tcharl]

Role is now totally idempotent for default configuration (to be honest, I don't know what I modified in my latest commit which makes the magic happen for the default role) so ready to merge for me. I slightly modified the role spec to reuse the existing lvm role: the previous version had some drawbacks IMO:

• The user was forced to have lvm2 package installed to run this role, which failed otherwise
• The VG was created the time this role was run: which could be very harmful in some use case
• The mrjsmith role do more than only consuming the 'lvol' ansible module.